zentol commented on a change in pull request #7251: [FLINK-11026][ES6] Rework 
creation of fat sql-client jars 
URL: https://github.com/apache/flink/pull/7251#discussion_r239812303
 
 

 ##########
 File path: flink-connectors/flink-connector-elasticsearch6/pom.xml
 ##########
 @@ -174,95 +174,6 @@ under the License.
 
        </dependencies>
 
-       <profiles>
-               <!-- Create SQL Client uber jars by default -->
-               <profile>
-                       <id>sql-jars</id>
-                       <activation>
-                               <property>
-                                       <name>!skipSqlJars</name>
-                               </property>
-                       </activation>
-                       <build>
-                               <plugins>
-                                       <plugin>
-                                               
<groupId>org.apache.maven.plugins</groupId>
-                                               
<artifactId>maven-shade-plugin</artifactId>
-                                               <executions>
-                                                       <execution>
-                                                               
<phase>package</phase>
-                                                               <goals>
-                                                                       
<goal>shade</goal>
-                                                               </goals>
-                                                               <configuration>
-                                                                       
<shadedArtifactAttached>true</shadedArtifactAttached>
-                                                                       
<shadedClassifierName>sql-jar</shadedClassifierName>
-                                                                       
<filters>
-                                                                               
<filter>
-                                                                               
        <artifact>*:*</artifact>
-                                                                               
        <!-- It is difficult to find out artifacts that are really required by 
ES. -->
-                                                                               
        <!-- We use hard filters for now to clean up the SQL JAR. -->
-                                                                               
        <excludes>
-                                                                               
                <exclude>com/carrotsearch/**</exclude>
-                                                                               
                <exclude>com/sun/**</exclude>
-                                                                               
                <exclude>com/tdunning/**</exclude>
-                                                                               
                <exclude>config/**</exclude>
-                                                                               
                <exclude>forbidden/**</exclude>
-                                                                               
                <exclude>joptsimple/**</exclude>
-                                                                               
                <exclude>META-INF/services/com.fasterxml.**</exclude>
-                                                                               
                <exclude>META-INF/services/org.apache.lucene.**</exclude>
-                                                                               
                <exclude>META-INF/services/org.elasticsearch.**</exclude>
-                                                                               
                <exclude>META-INF/versions/**</exclude>
-                                                                               
                <exclude>modules.txt</exclude>
-                                                                               
                <exclude>mozilla/**</exclude>
-                                                                               
                <exclude>org/HdrHistogram/**</exclude>
-                                                                               
                <exclude>org/joda/**</exclude>
-                                                                               
                <exclude>org/tartarus/**</exclude>
-                                                                               
                <exclude>org/yaml/**</exclude>
-                                                                               
                <exclude>plugins.txt</exclude>
-                                                                               
        </excludes>
-                                                                               
</filter>
-                                                                       
</filters>
-                                                                       
<relocations>
-                                                                               
<!-- Force relocation of all Elasticsearch dependencies. -->
-                                                                               
<relocation>
-                                                                               
        <pattern>org.apache.commons</pattern>
-                                                                               
        
<shadedPattern>org.apache.flink.elasticsearch6.shaded.org.apache.commons</shadedPattern>
-                                                                               
</relocation>
-                                                                               
<relocation>
-                                                                               
        <pattern>org.apache.http</pattern>
-                                                                               
        
<shadedPattern>org.apache.flink.elasticsearch6.shaded.org.apache.http</shadedPattern>
-                                                                               
</relocation>
-                                                                               
<relocation>
-                                                                               
        <pattern>org.apache.lucene</pattern>
-                                                                               
        
<shadedPattern>org.apache.flink.elasticsearch6.shaded.org.apache.lucene</shadedPattern>
-                                                                               
</relocation>
-                                                                               
<relocation>
-                                                                               
        <pattern>org.elasticsearch</pattern>
-                                                                               
        
<shadedPattern>org.apache.flink.elasticsearch6.shaded.org.elasticsearch</shadedPattern>
-                                                                               
</relocation>
-                                                                               
<relocation>
-                                                                               
        <pattern>org.apache.logging</pattern>
-                                                                               
        
<shadedPattern>org.apache.flink.elasticsearch6.shaded.org.apache.logging</shadedPattern>
-                                                                               
</relocation>
-                                                                               
<relocation>
-                                                                               
        <pattern>com.fasterxml.jackson</pattern>
-                                                                               
        
<shadedPattern>org.apache.flink.elasticsearch6.shaded.com.fasterxml.jackson</shadedPattern>
-                                                                               
</relocation>
-                                                                       
</relocations>
-                                                                       <!-- 
Relocate the table format factory service file. -->
-                                                                       
<transformers>
-                                                                               
<transformer 
implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
 
 Review comment:
   pulled in through the `shade-flink` execution

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to