tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka]
connection leak when partition discovery is disabled an…
URL: https://github.com/apache/flink/pull/7020#discussion_r240235652
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
##########
@@ -756,6 +756,20 @@ public void cancel() {
// the discovery loop may currently be sleeping
in-between
// consecutive discoveries; interrupt to shutdown faster
discoveryLoopThread.interrupt();
+ } else {
+ // when partition discovery is disabled,
+ // we should still call the close method.
+ // otherwise we may have connection leak,
+ // if open method throws an exception after
partitionDiscoverer is constructed.
+ // In this case, run method won't be executed
+ // and partitionDiscoverer.close() won't be called.
+ if (partitionDiscoverer != null) {
+ try {
+ partitionDiscoverer.close();
+ } catch (Exception e) {
+ LOG.error("failed to close
partitionDiscoverer", e);
+ }
+ }
Review comment:
I think we should not close the `partitionDiscoverer` here. Instead we
should close it in the `open` method if no longer needed and in the `run`
method when leaving the `kafkaFetcher` thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
