[
https://issues.apache.org/jira/browse/FLINK-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716594#comment-16716594
]
ASF GitHub Bot commented on FLINK-11074:
----------------------------------------
dianfu commented on issue #7253: [FLINK-11074] [table][tests] Enable harness
tests with RocksdbStateBackend and add harness tests for CollectAggFunction
URL: https://github.com/apache/flink/pull/7253#issuecomment-446122904
@twalthr Sorry for interrupt. It would be great if you can share some
thoughts on the changes of this PR. Thanks in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve the harness test to make it possible test with state backend
> --------------------------------------------------------------------
>
> Key: FLINK-11074
> URL: https://issues.apache.org/jira/browse/FLINK-11074
> Project: Flink
> Issue Type: Test
> Components: Table API & SQL
> Reporter: Dian Fu
> Assignee: Dian Fu
> Priority: Major
> Labels: pull-request-available
>
> Currently, the harness test can only test without state backend. If you use a
> DataView in the accumulator of the aggregate function, the DataView is a java
> object and held in heap, not replaced with StateMapView/StateListView which
> values are actually held in the state backend. We should improve the harness
> test to make it possible to test with state backend. Otherwise, issues such
> as FLINK-10674 could have never been found. With this harness test available,
> we could test the built-in aggregate functions which use the DataView more
> fine grained.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
