[
https://issues.apache.org/jira/browse/FLINK-11122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716673#comment-16716673
]
ASF GitHub Bot commented on FLINK-11122:
----------------------------------------
GJL opened a new pull request #7273: [FLINK-11122][core] Change signature of
WrappingProxyUtil#stripProxy(T)
URL: https://github.com/apache/flink/pull/7273
## What is the purpose of the change
*This fixes a type inference ambiguity by the Java 9 compiler.*
cc: @StefanRRichter
## Brief change log
- *Change signature of WrappingProxyUtil#stripProxy(T)*
## Verifying this change
This change is already covered by existing tests, such as
*SafetyNetCloseableRegistryTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> SafetyNetCloseableRegistryTest fails with ClassCastException
> ------------------------------------------------------------
>
> Key: FLINK-11122
> URL: https://issues.apache.org/jira/browse/FLINK-11122
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> When compiling and running {{SafetyNetCloseableRegistryTest}} with Java 9,
> some tests fail with a {{ClassCastException}}
> {noformat}
> java.lang.AssertionError: java.lang.ClassCastException:
> org.apache.flink.core.fs.local.LocalDataOutputStream cannot be cast to
> org.apache.flink.core.fs.WrappingProxyCloseable
> at
> org.apache.flink.core.fs.SafetyNetCloseableRegistry$PhantomDelegatingCloseableRef.<init>(SafetyNetCloseableRegistry.java:156)
> at
> org.apache.flink.core.fs.SafetyNetCloseableRegistry.doRegister(SafetyNetCloseableRegistry.java:99)
> at
> org.apache.flink.core.fs.SafetyNetCloseableRegistry.doRegister(SafetyNetCloseableRegistry.java:50)
> at
> org.apache.flink.util.AbstractCloseableRegistry.registerCloseable(AbstractCloseableRegistry.java:79)
> at
> org.apache.flink.core.fs.ClosingFSDataOutputStream.wrapSafe(ClosingFSDataOutputStream.java:101)
> at
> org.apache.flink.core.fs.SafetyNetWrapperFileSystem.create(SafetyNetWrapperFileSystem.java:127)
> at
> org.apache.flink.core.fs.SafetyNetCloseableRegistryTest$3.go(SafetyNetCloseableRegistryTest.java:120)
> at
> org.apache.flink.core.testutils.CheckedThread.run(CheckedThread.java:74)
> {noformat}
> This is due to the problematic signature in
> {{WrappingProxyUtil#stripProxy(T)}}, which expects a generic type {{T}} and
> also returns {{T}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
