[ 
https://issues.apache.org/jira/browse/FLINK-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717375#comment-16717375
 ] 

ASF GitHub Bot commented on FLINK-11080:
----------------------------------------

zentol closed pull request #7247: [FLINK-11080][ES] Rework shade-plugin filters
URL: https://github.com/apache/flink/pull/7247
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-connectors/flink-connector-elasticsearch6/pom.xml 
b/flink-connectors/flink-connector-elasticsearch6/pom.xml
index 40b9ab6efaf..57d10795beb 100644
--- a/flink-connectors/flink-connector-elasticsearch6/pom.xml
+++ b/flink-connectors/flink-connector-elasticsearch6/pom.xml
@@ -197,29 +197,57 @@ under the License.
                                                                <configuration>
                                                                        
<shadedArtifactAttached>true</shadedArtifactAttached>
                                                                        
<shadedClassifierName>sql-jar</shadedClassifierName>
+                                                                       
<artifactSet>
+                                                                               
<includes>
+                                                                               
        <include>*:*</include>
+                                                                               
</includes>
+                                                                               
<excludes>
+                                                                               
        <!-- These dependencies are not required. -->
+                                                                               
        <exclude>com.carrotsearch:hppc</exclude>
+                                                                               
        <exclude>com.tdunning:t-digest</exclude>
+                                                                               
        <exclude>joda-time:joda-time</exclude>
+                                                                               
        <exclude>net.sf.jopt-simple:jopt-simple</exclude>
+                                                                               
        <exclude>org.elasticsearch:jna</exclude>
+                                                                               
        <exclude>org.hdrhistogram:HdrHistogram</exclude>
+                                                                               
        <exclude>org.yaml:snakeyaml</exclude>
+                                                                               
</excludes>
+                                                                       
</artifactSet>
                                                                        
<filters>
                                                                                
<filter>
-                                                                               
        <artifact>*:*</artifact>
-                                                                               
        <!-- It is difficult to find out artifacts that are really required by 
ES. -->
-                                                                               
        <!-- We use hard filters for now to clean up the SQL JAR. -->
+                                                                               
        <artifact>org.elasticsearch:elasticsearch</artifact>
                                                                                
        <excludes>
-                                                                               
                <exclude>com/carrotsearch/**</exclude>
-                                                                               
                <exclude>com/sun/**</exclude>
-                                                                               
                <exclude>com/tdunning/**</exclude>
                                                                                
                <exclude>config/**</exclude>
+                                                                               
                <exclude>modules.txt</exclude>
+                                                                               
                <exclude>plugins.txt</exclude>
+                                                                               
                <exclude>org/joda/**</exclude>
+                                                                               
        </excludes>
+                                                                               
</filter>
+                                                                               
<filter>
+                                                                               
        
<artifact>org.elasticsearch.client:elasticsearch-rest-high-level-client</artifact>
+                                                                               
        <excludes>
                                                                                
                <exclude>forbidden/**</exclude>
-                                                                               
                <exclude>joptsimple/**</exclude>
+                                                                               
        </excludes>
+                                                                               
</filter>
+                                                                               
<filter>
+                                                                               
        <artifact>org.apache.httpcomponents:httpclient</artifact>
+                                                                               
        <excludes>
+                                                                               
                <exclude>mozilla/**</exclude>
+                                                                               
        </excludes>
+                                                                               
</filter>
+                                                                               
<filter>
+                                                                               
        <artifact>org.apache.lucene:lucene-analyzers-common</artifact>
+                                                                               
        <excludes>
+                                                                               
                <exclude>org/tartarus/**</exclude>
+                                                                               
        </excludes>
+                                                                               
</filter>
+                                                                               
<filter>
+                                                                               
        <artifact>*:*</artifact>
+                                                                               
        <excludes>
+                                                                               
                <!-- exclude Java 9 specific classes as otherwise the 
shade-plugin crashes -->
+                                                                               
                <exclude>META-INF/versions/**</exclude>
                                                                                
                <exclude>META-INF/services/com.fasterxml.**</exclude>
                                                                                
                <exclude>META-INF/services/org.apache.lucene.**</exclude>
                                                                                
                <exclude>META-INF/services/org.elasticsearch.**</exclude>
-                                                                               
                <exclude>META-INF/versions/**</exclude>
-                                                                               
                <exclude>modules.txt</exclude>
-                                                                               
                <exclude>mozilla/**</exclude>
-                                                                               
                <exclude>org/HdrHistogram/**</exclude>
-                                                                               
                <exclude>org/joda/**</exclude>
-                                                                               
                <exclude>org/tartarus/**</exclude>
-                                                                               
                <exclude>org/yaml/**</exclude>
-                                                                               
                <exclude>plugins.txt</exclude>
                                                                                
        </excludes>
                                                                                
</filter>
                                                                        
</filters>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Define flink-connector-elasticsearch6 uber-jar dependencies via artifactSet
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-11080
>                 URL: https://issues.apache.org/jira/browse/FLINK-11080
>             Project: Flink
>          Issue Type: Improvement
>          Components: ElasticSearch Connector, SQL Client
>    Affects Versions: 1.5.5, 1.6.2, 1.7.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.6, 1.6.3, 1.8.0, 1.7.1
>
>
> Similar to FLINK-11005.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to