[
https://issues.apache.org/jira/browse/FLINK-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718822#comment-16718822
]
ASF GitHub Bot commented on FLINK-11048:
----------------------------------------
mxm commented on a change in pull request #7249: [FLINK-11048] Ability to
programmatically execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#discussion_r240976627
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
##########
@@ -283,6 +275,14 @@ public JobExecutionResult execute(String jobName) throws
ProgramInvocationExcept
return executeRemotely(streamGraph, jarFiles);
}
+ /**
+ * Execute the job with savepoint restore.
+ */
+ public JobExecutionResult execute(String jobName,
SavepointRestoreSettings savepointRestoreSettings) throws
ProgramInvocationException {
+ this.savepointRestoreSettings = savepointRestoreSettings;
+ return execute(jobName);
Review comment:
This would still be an implicit setter. I don't think the settings should be
persisted across executions. I would also remove the field.
Could you just call `executeRemotely` directly here with the settings as
parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ability to programmatically execute streaming pipeline with savepoint restore
>
> -------------------------------------------------------------------------------
>
> Key: FLINK-11048
> URL: https://issues.apache.org/jira/browse/FLINK-11048
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Affects Versions: 1.7.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Minor
> Labels: pull-request-available
>
> RemoteStreamEnvironment.execute doesn't support restore from savepoint,
> though the underlying ClusterClient does. Add an explicit "execute remotely"
> that can be used by downstream projects.
> [https://lists.apache.org/thread.html/6fff05d4a8444d1c6fa139d63605d51f610caff46605a4cdbb35cd50@%3Cdev.flink.apache.org%3E]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
