dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add
UnBounded FlatAggregate operator to streaming Table API
URL: https://github.com/apache/flink/pull/7209#discussion_r240930625
##########
File path:
flink-libraries/flink-table-common/src/main/java/org/apache/flink/table/utils/RetractableCollector.java
##########
@@ -16,21 +16,29 @@
* limitations under the License.
*/
-package org.apache.flink.table.sinks
+package org.apache.flink.table.utils;
-import org.apache.flink.streaming.api.datastream.DataStream
-import org.apache.flink.table.api.Table
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.util.Collector;
/**
- * Defines an external [[TableSink]] to emit streaming [[Table]] with only
insert changes.
- *
- * If the [[Table]] is also modified by update or delete changes, a
- * [[org.apache.flink.table.api.TableException]] will be thrown.
- *
- * @tparam T Type of [[DataStream]] that this [[TableSink]] expects and
supports.
- */
-trait AppendStreamTableSink[T] extends StreamTableSink[T] {
+ * Collects a record and forwards it. The collector can output retract
messages with retract method.
+ * Currently, RetractableCollector is used in TableAggregateFunction.
+ */
+@Internal
+public abstract class RetractableCollector<T> implements Collector<T> {
+
+ /**
+ * Collect a record.
+ *
+ * @param record The record to collect.
+ */
+ public abstract void collect(T record);
Review comment:
the method collect can be removed as it already exists in the parent
interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
