[
https://issues.apache.org/jira/browse/FLINK-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718990#comment-16718990
]
Yangze Guo commented on FLINK-11142:
------------------------------------
[~hequn8128] Thank you for the reply!
It sounds like a good idea. But I think we can just make it clear in the
documentation if we decide to regard this as a feature. In current design, we
implicitly treat the *ByPosition* mode as a special case of *ByName* mode. So,
the projection behavior in *ByPosition* mode is reasonable.
But I agree that it would be better if we inform the user in a more direct way
that the projection has occurred, in both *ByPosition* mode and *ByName* mode.
Maybe we can subdivide the method to withProject and withoutProject version.
> Undefined behavior in the conversion from DataStream/DataSet to Table
> ---------------------------------------------------------------------
>
> Key: FLINK-11142
> URL: https://issues.apache.org/jira/browse/FLINK-11142
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.7.0
> Reporter: Yangze Guo
> Assignee: Hequn Cheng
> Priority: Minor
>
> When we try to convert DataStream/DataSet to Table. There are two ways of
> adding schema information, *ByName* or *ByPosition*.
> This feature first proposed in [this
> pr|https://github.com/apache/flink/pull/5132].
> In *ByPosition* mode, the current code does not check if the number of fields
> less than its in DataStream/DataSet. This may cause undefined behavior, e.g.
> make a projection in *ByPosition* mode.
> We can either fix it by adding some checking or regard this as a feature and
> just improve the doc to clarify it. In my opinion, the latter way seems
> better.
> [~twalthr] Could you take a look at it when you free?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
