dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add
UnBounded FlatAggregate operator to streaming Table API
URL: https://github.com/apache/flink/pull/7209#discussion_r241285918
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
##########
@@ -295,6 +295,15 @@ abstract class CodeGenerator(
generateResultExpression(input1AccessExprs ++ input2AccessExprs,
returnType, resultFieldNames)
}
+ /**
+ * Generates an expression from the input.
+ */
+ def generateFieldAccessExprs: Seq[GeneratedExpression] = {
Review comment:
Is it possible to avoid this change? Seems that you can use
CodeGenerator#generateConverterResultExpression
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
