sunjincheng121 commented on a change in pull request #7253: [FLINK-11074]
[table][tests] Enable harness tests with RocksdbStateBackend and add harness
tests for CollectAggFunction
URL: https://github.com/apache/flink/pull/7253#discussion_r241612651
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala
##########
@@ -491,13 +491,83 @@ class HarnessTestBase {
distinctCountFuncName,
distinctCountAggCode)
+ def createHarnessTester[KEY, IN, OUT](
+ dataStream: DataStream[_],
+ prefixOperatorName: String)
Review comment:
How a bout add `aggFieldAlias: String = ""`, for resolve scenarios where
GroupBy is included in multiple UNION clauses. e.g:
```
(SELECT b, max(a) as maxA FROM T GROUP BY b)
UNION (
SELECT b, min(a) as minA FROM (
SELECT a, b FROM T GROUP BY a, b
) GROUP BY b
)
```
And we using this method as follows: `createHarnessTester(xx, "groupBy",
"minA")`。
I didn't find a case where I had to test it in this way, it was just an
enhanced suggestion.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
