mxm commented on a change in pull request #7249: [FLINK-11048] Ability to
programmatically execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#discussion_r241825068
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
##########
@@ -283,6 +275,14 @@ public JobExecutionResult execute(String jobName) throws
ProgramInvocationExcept
return executeRemotely(streamGraph, jarFiles);
}
+ /**
+ * Execute the job with savepoint restore.
+ */
+ public JobExecutionResult execute(String jobName,
SavepointRestoreSettings savepointRestoreSettings) throws
ProgramInvocationException {
+ this.savepointRestoreSettings = savepointRestoreSettings;
+ return execute(jobName);
Review comment:
I understand that it is one-time, but I would still prefer to not have this
side effect here. Could you either 1) make the SavepointSettings a `final`
field and initialize it in the constructor or 2) provide the settings here as a
parameter which is not stored in a field? Sorry for the hassle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
