TisonKun commented on a change in pull request #7302: [FLINK-11156] [tests]
Reconcile powermock with JDK 9
URL: https://github.com/apache/flink/pull/7302#discussion_r241907057
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
##########
@@ -128,7 +145,9 @@ public ZooKeeperCompletedCheckpointStore(
// All operations will have the path as root
this.client = client.usingNamespace(client.getNamespace() +
checkpointsPath);
- this.checkpointsInZooKeeper = new
ZooKeeperStateHandleStore<>(this.client, stateStorage);
+ this.checkpointsInZooKeeper = (checkpointsInZooKeeper != null) ?
Review comment:
I am not super happy with this line. This is why I have given up this way
the first time. I'd like to learn whether this style is OK in Flink or we tend
to build such a testing constructor in another way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
