hequn8128 commented on a change in pull request #6236: [FLINK-9699] [table] Add
api to replace registered table
URL: https://github.com/apache/flink/pull/6236#discussion_r241972700
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
##########
@@ -238,22 +241,12 @@ abstract class StreamTableEnvironment(
}
val configuredSink = tableSink.configure(fieldNames, fieldTypes)
- registerTableSinkInternal(name, configuredSink)
+ registerTableSinkInternal(name, configuredSink, replace)
}
- /**
- * Registers an external [[TableSink]] with already configured field names
and field types in
- * this [[TableEnvironment]]'s catalog.
- * Registered sink tables can be referenced in SQL DML statements.
- *
- * @param name The name under which the [[TableSink]] is registered.
- * @param configuredSink The configured [[TableSink]] to register.
- */
- def registerTableSink(name: String, configuredSink: TableSink[_]): Unit = {
- registerTableSinkInternal(name, configuredSink)
- }
-
- private def registerTableSinkInternal(name: String, configuredSink:
TableSink[_]): Unit = {
+ protected def registerTableSinkInternal(name: String,
Review comment:
Format the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
