dawidwys commented on issue #7310: [FLINK-10594][table] Add Subsets for CEP URL: https://github.com/apache/flink/pull/7310#issuecomment-447638405 Hi @buptljy thank you for your contribution, Unfortunately I am afraid this PR lacks proper design and misses a lot of details how `SUBSET` clause affects different clauses. The main problem that is not solved by this PR I am aware of is what happens if user uses a subset in `AFTER MATCH SKIP` clause. Such case is not supported in cep library. Before reviewing the code itself I would really appreciate a proper description how it affects other cases and how do you want to solve them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
