hequn8128 commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r242035345
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/ExplainTest.scala
##########
@@ -65,21 +64,6 @@ class ExplainTest extends AbstractTestBase {
assertEquals(expect, result)
}
- @Test
Review comment:
As we add the `RemoveDataStreamUpsertToRetractionRule` rule, we can check
the remove logic in `FromUpsertStreamTest.testRemoveUpsertToRetraction()` while
before, the `DataStreamUpsertToRetraction` node has not been removed and has to
be checked in the execution plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
