TisonKun commented on a change in pull request #7303: [FLINK-10569] [tests] Get
rid of Scheduler and Instance from valid tests
URL: https://github.com/apache/flink/pull/7303#discussion_r242054408
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/VertexSlotSharingTest.java
##########
@@ -90,12 +90,12 @@ public void testAssignSlotSharingGroup() {
new SerializedValue<>(new ExecutionConfig()),
AkkaUtils.getDefaultTimeout(),
new NoRestartStrategy(),
- new
Scheduler(TestingUtils.defaultExecutionContext()));
+ new TestingSlotProvider(ignored -> new
CompletableFuture<>()));
eg.attachJobGraph(vertices);
// verify that the vertices are all in the same slot
sharing group
- SlotSharingGroup group1 = null;
- SlotSharingGroup group2 = null;
+ SlotSharingGroup group1;
Review comment:
It is accidental to be in the same commit. I am not quite sure if I have to
revert it. What is the most convenient commits layout for merging a pull
request and how does flink deal with such "code cleaning" works? @zentol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
