igalshilman commented on a change in pull request #7313: 
[FLINK-11116][fs-connector] Removed randomness from HDFS and Local fs writers.
URL: https://github.com/apache/flink/pull/7313#discussion_r242461906
 
 

 ##########
 File path: 
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriter.java
 ##########
 @@ -60,6 +60,12 @@ public 
HadoopRecoverableWriter(org.apache.hadoop.fs.FileSystem fs) {
        @Override
        public RecoverableFsDataOutputStream open(Path filePath) throws 
IOException {
                final org.apache.hadoop.fs.Path targetFile = 
HadoopFileSystem.toHadoopPath(filePath);
+
+               // the finalized part must not exist already
+               if (fs.exists(targetFile)) {
 
 Review comment:
   Can you please help me to understand:
   what is the assumption that the master had, that now is lost and requires 
this check? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to