azagrebin commented on a change in pull request #6777: [FLINK-10461] [State 
Backends, Checkpointing] Speed up download files when restore from DFS
URL: https://github.com/apache/flink/pull/6777#discussion_r242901812
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ##########
 @@ -120,6 +120,9 @@
        /** This determines if incremental checkpointing is enabled. */
        private final TernaryBoolean enableIncrementalCheckpointing;
 
+       /** Thread number used to download from DFS when restore, default 
value: 1. */
+       private int numberOfRestoringThreads;
 
 Review comment:
   We introduced a setter for it: `setNumberOfRestoringThreads`, not to explode 
the number of constructor args like for `enableIncrementalCheckpointing`. At 
the moment `RocksDBStateBackend` basically serves as a configuration object and 
factory for the keyed and operator backends.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to