zentol opened a new pull request #7336: [FLINK-11194][hbase] Use type instead 
of classifier
URL: https://github.com/apache/flink/pull/7336
 
 
   ## What is the purpose of the change
   
   The hbase-connector module has been disabling the shade-plugin due to an 
infinite loop that occurs when creating the dependency-reduced pom. As a result 
the released pom contained unresolved properties for the scala version, which 
breaks the connector when using scala 2.12.
   
   The loop is caused by having multiple instances for the same dependency with 
different classifiers. Classifiers are suffixes that added to jars; most 
notable "tests" for the test-jar.
   The plugin however _can_ handle multiple instances with different _types_, 
like `test-jar`.
   
   Since we refer to the same artifact regardless we can just use the `types` 
parameter to select the test-jar, preventing the loop.
   
   ## Brief change log
   
   * use `<type>` instead of  `<classifier>`
   * remove custom shade-plugin configuration
   
   ## Verifying this change
   
   Compile the module and ensure that the dependency-reduced-pom.xml is created 
and does not contain unresolved properties.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to