[ 
https://issues.apache.org/jira/browse/FLINK-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725032#comment-16725032
 ] 

Timo Walther edited comment on FLINK-11200 at 12/19/18 2:14 PM:
----------------------------------------------------------------

[~hequn8128] You are right. I haven't seen the transitive class dependencies. 
Would be great if we can find a better solution with cleaner interfaces than 
just porting {{ListViewTypeInfo}}, {{ListViewSerializer}} into 
{{table-common}}. In my opinion, those classes don't fit 100% into the a module 
that is shared across a lot of Flink modules. But if you find no cleaner way 
while maintaining backwards compatibility, feel free to port them as well.


was (Author: twalthr):
You are right. I haven't seen the transitive class dependencies. Would be great 
if we can find a better solution with cleaner interfaces than just porting 
{{ListViewTypeInfo}}, {{ListViewSerializer}} into {{table-common}}. In my 
opinion, those classes don't fit 100% into the a module that is shared across a 
lot of Flink modules. But if you find no cleaner way while maintaining 
backwards compatibility, feel free to port them as well.

> Port DataView classes to flink-table-common
> -------------------------------------------
>
>                 Key: FLINK-11200
>                 URL: https://issues.apache.org/jira/browse/FLINK-11200
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Hequn Cheng
>            Priority: Major
>
> {{DataView}} are used within aggregate functions for more efficient state 
> management. Logically, they should have been ported in FLINK-10689.
> This issue only includes {{org.apache.flink.table.api.dataview.*}} and 
> {{org.apache.flink.table.dataview.StateListView/StateMapView}}. The latter 
> one is shared between planning and runtime phase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to