zentol commented on a change in pull request #7260: [hotfix][docs] Fix typo and 
make improvement in Kafka Connectors doc
URL: https://github.com/apache/flink/pull/7260#discussion_r243232818
 
 

 ##########
 File path: docs/dev/connectors/kafka.md
 ##########
 @@ -713,14 +713,14 @@ the consumers until `transaction1` is committed or 
aborted. This has two implica
 **Note**:  `Semantic.EXACTLY_ONCE` mode uses a fixed size pool of 
KafkaProducers
 per each `FlinkKafkaProducer011` instance. One of each of those producers is 
used per one
 checkpoint. If the number of concurrent checkpoints exceeds the pool size, 
`FlinkKafkaProducer011`
-will throw an exception and will fail the whole application. Please configure 
max pool size and max
-number of concurrent checkpoints accordingly.
+will throw an exception and will fail the whole application. Please configure 
max pool size(`FlinkKafkaProducer011.kafkaProducersPoolSize`) 
+and max number of concurrent 
checkpoints(`CheckpointConfig.maxConcurrentCheckpoints`) accordingly.
 
 Review comment:
   the reference to `CheckpointConfig` doesn't belong here. Instead there 
should be a paragraph for this feature in the relevant section of the 
documentation (Checkpoints/Tuning checkpointing) that we refer to here. There's 
a small note 
[here](https://ci.apache.org/projects/flink/flink-docs-release-1.7/ops/state/large_state_tuning.html#tuning-checkpointing)
 that we could extend instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to