tweise commented on a change in pull request #7249: [FLINK-11048] Ability to 
programmatically execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#discussion_r243355968
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
 ##########
 @@ -233,6 +301,36 @@ protected JobExecutionResult executeRemotely(StreamGraph 
streamGraph, List<URL>
                }
        }
 
+       @Override
+       public JobExecutionResult execute(String jobName) throws 
ProgramInvocationException {
+               StreamGraph streamGraph = getStreamGraph();
+               streamGraph.setJobName(jobName);
+               transformations.clear();
+               return executeRemotely(streamGraph, jarFiles);
+       }
+
+       /**
+        * Executes the remote job.
+        *
+        * <p>Note: This method exposes stream graph internal in the public 
API, but cannot be removed for backward compatibility.
+        * @param streamGraph
+        *            Stream Graph to execute
+        * @param jarFiles
+        *                        List of jar file URLs to ship to the cluster
+        * @return The result of the job execution, containing elapsed time and 
accumulators.
+        */
+       protected JobExecutionResult executeRemotely(StreamGraph streamGraph, 
List<URL> jarFiles) throws ProgramInvocationException {
 
 Review comment:
   @mxm do you think we should mark it deprecated, since it is the major cause 
of difficulties evolving this code? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to