tweise commented on a change in pull request #6968: [FLINK-4582] [kinesis]
Consuming data from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r243472949
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
##########
@@ -193,18 +193,32 @@ public static Properties
replaceDeprecatedProducerKeys(Properties configProps) {
return configProps;
}
- public static Properties replaceDeprecatedConsumerKeys(Properties
configProps) {
- HashMap<String, String> deprecatedOldKeyToNewKeys = new
HashMap<>();
-
deprecatedOldKeyToNewKeys.put(ConsumerConfigConstants.STREAM_DESCRIBE_BACKOFF_BASE,
ConsumerConfigConstants.LIST_SHARDS_BACKOFF_BASE);
-
deprecatedOldKeyToNewKeys.put(ConsumerConfigConstants.STREAM_DESCRIBE_BACKOFF_MAX,
ConsumerConfigConstants.LIST_SHARDS_BACKOFF_MAX);
-
deprecatedOldKeyToNewKeys.put(ConsumerConfigConstants.STREAM_DESCRIBE_BACKOFF_EXPONENTIAL_CONSTANT,
ConsumerConfigConstants.LIST_SHARDS_BACKOFF_EXPONENTIAL_CONSTANT);
- for (Map.Entry<String, String> entry :
deprecatedOldKeyToNewKeys.entrySet()) {
- String deprecatedOldKey = entry.getKey();
+ /**
+ * <p>
+ * A set of configuration paremeters associated with the
describeStreams API may be used if:
+ * 1) an legacy client wants to consume from Kinesis
+ * 2) a current client wants to consumer from DynamoDB streams
+ *
+ * In the context of 1), the set of configurations needs to be
translated to the corresponding
+ * configurations in the Kinesis listShards API. In the mean time, keep
these configs since
+ * they may be useful in the context of 2), i.e., polling data from a
DynamoDB stream.
Review comment:
"may be useful" => "are applicable"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
