TisonKun commented on a change in pull request #7302: [FLINK-11156] [tests]
Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9
URL: https://github.com/apache/flink/pull/7302#discussion_r243508511
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
##########
@@ -107,11 +108,27 @@
* @throws Exception
*/
public ZooKeeperCompletedCheckpointStore(
- int maxNumberOfCheckpointsToRetain,
- CuratorFramework client,
- String checkpointsPath,
- RetrievableStateStorageHelper<CompletedCheckpoint>
stateStorage,
- Executor executor) throws Exception {
+ int maxNumberOfCheckpointsToRetain,
+ CuratorFramework client,
+ String checkpointsPath,
+ RetrievableStateStorageHelper<CompletedCheckpoint> stateStorage,
+ Executor executor) throws Exception {
+ this(maxNumberOfCheckpointsToRetain,
+ client,
+ checkpointsPath,
+ stateStorage,
+ executor,
+ null);
Review comment:
@zentol I try to get rid of the null check by adapting the client first.
However, this introduces two more `private` constructors for the unified path.
I'd like to hear from your advice on this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
