TisonKun opened a new pull request #7355: [hotfix] [dispatcher] Improve signature of #waitForTerminatingJobManager URL: https://github.com/apache/flink/pull/7355 ## What is the purpose of the change `#waitForTerminatingJobManager` get a `JobGraph`, terminate the previous running future(if there was) and then apply a new action. The `jobId` should be always the same as `jobGraph.getJobID()`. We change the signature to improve understandability. ## Brief change log `#waitForTerminatingJobManager(JobID, JobGraph, Function)` → `#waitForTerminatingJobManager(JobGraph, Function)`, and the `JobID` is now generated by `JobGraph` ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (**no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**) - The serializers: (**no**) - The runtime per-record code paths (performance sensitive): (**no**) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**) - The S3 file system connector: (**no**) ## Documentation - Does this pull request introduce a new feature? (**no**) - If yes, how is the feature documented? (**not applicable**) cc @tillrohrmann @StefanRRichter
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
