azagrebin commented on a change in pull request #7351: [FLINK-11008][State
Backends, Checkpointing]SpeedUp upload state files using multithread
URL: https://github.com/apache/flink/pull/7351#discussion_r244002977
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -220,6 +220,9 @@
/** Thread number used to download from DFS when restore. */
private final int restoringThreadNum;
+ /** Thread number used to upload to DFS when snapshot. */
+ private final int uploadingThreadNum;
Review comment:
I would align it with `restoringThreadNum` and name it
`snapshottingThreadNum`. I think it would be even better to name them both
`numberOfRestoringThreads` and `numberOfSnapshottingThreads`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
