KarmaGYZ commented on a change in pull request #7365: [hotfix][docs] Fix typo
and make improvement in User-defined Sources …
URL: https://github.com/apache/flink/pull/7365#discussion_r244066191
##########
File path: docs/dev/table/sourceSinks.md
##########
@@ -285,7 +285,7 @@ NestedFieldsProjectableTableSource[T] {
</div>
</div>
-* `projectNestedField(fields, nestedFields)`: Returns a *copy* of the
`TableSource` with adjusted physical return type. Fields of the physical return
type may be removed or reordered but their type must not be changed. The
contract of this method is essentially the same as for the
`ProjectableTableSource.projectFields()` method. In addition, the
`nestedFields` parameter contains for each field index in the `fields` list, a
list of paths to all nested fields that are accessed by the query. All other
nested fields do not need to be read, parsed, and set in the records that are
produced by the `TableSource`. **IMPORTANT** the types of the projected fields
must not be changed but unused fields may be set to null or to a default value.
+* `projectNestedField(fields, nestedFields)`: Returns a *copy* of the
`TableSource` with adjusted physical return type. Fields of the physical return
type may be removed or reordered but their type must not be changed. The
contract of this method is essentially the same as for the
`ProjectableTableSource.projectFields()` method. In addition, the
`nestedFields` parameter contains for each field index in the `fields` list, a
list of paths to all nested fields that are accessed by the query. All other
nested fields do not need to be read, parsed, and set in the records that are
produced by the `TableSource`. **IMPORTANT** the types of the projected fields
must not be changed but unused fields may be set to `null` or to a default
value.
Review comment:
Thanks for the quick review!
I put quotation mark on the word **null** in the last line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
