EronWright opened a new pull request #7390: [FLINK-11240] [table] External 
Catalog Factory and Descriptor
URL: https://github.com/apache/flink/pull/7390
 
 
   ## What is the purpose of the change
   
   Implements the descriptor and factory infrastructure for external catalogs.
   
   I found it counterproductive to involve `ConnectorDescriptor` for external 
catalogs.  That type was designed to support a mix-and-match between connector 
and format.   See FLINK-11241 for more.
   
   On the topic of the transition to `flink-table-common`, I found it 
convenient to keep the new types in `flink-table` until `ExternalCatalog` moves 
(FLINK-10755).   Java was used whenever possible.
   
   Closes FLINK-11240.
   
   ## Brief change log
   
   - Add `ExternalCatalogDescriptor`
   - Add `ExternalCatalogDescriptorValidator`
   - Add `ExternalCatalogFactory`
   - Add `TableFactoryUtil::findAndCreateExternalCatalog`
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   - Added unit test `ExternalCatalogDescriptorTest` for descriptors
   - Added unit test `ExternalCatalogFactoryServiceTest` for factory discovery
   - Added a sample factory `TestExternalCatalogFactory` for test purposes 
which serves the catalog provided by the existing 
`CommonTestData::getInMemoryTestCatalog`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to