Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-134567455
Really good work @r-pogalz. I had only some minor comments concerning style
and test cases.
I like your approach to split the implementation of FLINK-687 into multiple
parts. This makes it far easier to review. Concerning the description of
FLINK-2106, you haven't integrated the outer sort merge join into the optimizer
and the API, yet. I guess this will happen as a next step. Maybe you can update
the description of FLINK-2106 accordingly.
Other than that, the PR looks good to me :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
