fatjoshua commented on a change in pull request #7078: [FLINK-10848][YARN]
properly remove YARN ContainerRequest upon container allocation success
URL: https://github.com/apache/flink/pull/7078#discussion_r244704879
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -361,7 +361,8 @@ public void onContainersAllocated(List<Container>
containers) {
"Received new container: {} - Remaining
pending container requests: {}",
container.getId(),
numPendingContainerRequests);
-
+
resourceManagerClient.removeContainerRequest(new AMRMClient.ContainerRequest(
Review comment:
maybe we can move this removeContainerRequest before this for loop, use a
indepedent for loop to do this remove staff.
```suggestion
resourceManagerClient.removeContainerRequest(new AMRMClient.ContainerRequest(
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
