suez1224 commented on a change in pull request #7356: [FLINK-10868][flink-yarn]
Enforce maximum failed TMs in YarnResourceManager
URL: https://github.com/apache/flink/pull/7356#discussion_r245156585
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -381,11 +393,20 @@ public void onContainersAllocated(List<Container>
containers) {
} catch (Throwable t) {
log.error("Could not start
TaskManager in container {}.", container.getId(), t);
+
failedContainerSoFar.getAndAdd(1);
// release the failed container
workerNodeMap.remove(resourceId);
resourceManagerClient.releaseAssignedContainer(container.getId());
- // and ask for a new one
-
requestYarnContainerIfRequired(container.getResource(),
container.getPriority());
+
+ if
(failedContainerSoFar.intValue() < maxFailedContainers) {
Review comment:
I think we need to fail the cluster when failedContainerSoFar exceed the
threshold after line 362 as well, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
