asfgit closed pull request #7386: [FLINK-11234][table][tests] fix
ExternalTableCatalogBuilder::supportsBatch
URL: https://github.com/apache/flink/pull/7386
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
index 45414ee3ff6..ce57070ac98 100644
---
a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
+++
b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
@@ -270,8 +270,8 @@ class ExternalCatalogTableBuilder(private val
connectorDescriptor: ConnectorDesc
* Explicitly declares this external table for supporting only batch
environments.
*/
def supportsBatch(): ExternalCatalogTableBuilder = {
- isBatch = false
- isStreaming = true
+ isBatch = true
+ isStreaming = false
this
}
diff --git
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/utils/CommonTestData.scala
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/utils/CommonTestData.scala
index 64fcc8ac7c4..1209595837b 100644
---
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/utils/CommonTestData.scala
+++
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/utils/CommonTestData.scala
@@ -85,7 +85,9 @@ object CommonTestData {
.withSchema(schemaDesc1)
if (isStreaming) {
- externalTableBuilder1.inAppendMode()
+ externalTableBuilder1.supportsStreaming().inAppendMode()
+ } else {
+ externalTableBuilder1.supportsBatch()
}
val csvRecord2 = Seq(
@@ -126,7 +128,9 @@ object CommonTestData {
.withSchema(schemaDesc2)
if (isStreaming) {
- externalTableBuilder2.inAppendMode()
+ externalTableBuilder2.supportsStreaming().inAppendMode()
+ } else {
+ externalTableBuilder2.supportsBatch()
}
val tempFilePath3 = writeToTempFile("", "csv-test3", "tmp")
@@ -145,7 +149,9 @@ object CommonTestData {
.withSchema(schemaDesc3)
if (isStreaming) {
- externalTableBuilder3.inAppendMode()
+ externalTableBuilder3.supportsStreaming().inAppendMode()
+ } else {
+ externalTableBuilder3.supportsBatch()
}
val catalog = new InMemoryExternalCatalog("test")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
