twalthr commented on a change in pull request #7265: [FLINK-10964] SQL-client
throws exception when paging through finished batch query
URL: https://github.com/apache/flink/pull/7265#discussion_r245620307
##########
File path:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliResultView.java
##########
@@ -150,9 +151,10 @@ protected void openRow() {
view.open(); // enter view
}
- protected void stopRetrieval() {
+ protected void stopRetrieval(TypedResult.ResultType jobStatus) {
// stop retrieval
refreshThread.isRunning = false;
+ refreshThread.jobStatus = jobStatus;
Review comment:
Switch these two statements because otherwise the refresh thread can already
do side effects when `isRunning` is set to false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
