kl0u commented on issue #7287: [FLINK-11140][streaming] Fix empty child path check in Buckets URL: https://github.com/apache/flink/pull/7287#issuecomment-451951504 @Matrix42 I have reviewed your PR and I have some comments. Given that the PR is closed and I cannot submit a review, I pushed my changes in my branch here: https://github.com/kl0u/flink/tree/buckets Feel free to integrate them and open a new PR and I can review it again. In a nutshell, the changes that I propose are: 1) move the new test in a separate class called `BucketAssignerITCases` where we can add in the future more tests 2) now the test just checks that no exception is thrown, but it does not test that the path is the expected one. For this, I propose to change the return type of the `Buckets#onElement(...)` to `Bucket<IN, BucketID>`, and do assertions on that. All these are included in my branch. Feel free to ping me when you open the new PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
