tzulitai opened a new pull request #7428: [FLINK-11280] [state backends] Let RocksDBSerializedCompositeKeyBuilder accept key serializer lazily URL: https://github.com/apache/flink/pull/7428 ## What is the purpose of the change This PR fixes the failing test in master: `StateBackendMigrationTestBase.testStateBackendRestoreSucceedsIfNewKeySerializerRequiresReconfiguration`. The failing test indicates that a key serializer that was supposed to have been reconfigured was still being used. Serializers are assumed to be immutable, and therefore when a reconfiguration occurs, the key serializer instance to use would have changed from the originally provided key serializer. The problem is in the `RocksDBSerializedCompositeKeyBuilder`, which keeps a reference to the original key serializer and always uses that. This essentially ignores any key serializer reconfiguration that may have happened. Prior to this PR, the `RocksDBSerializedCompositeKeyBuilder` expects a key serializer when creating the builder. This PR fixes the failing tests by changing the usage of `RocksDBSerializedCompositeKeyBuilder` so that the key serializer is only provided lazily when the builder is used to build a composite serialized key. ## Verifying this change The previously failing test `StateBackendMigrationTestBase.testStateBackendRestoreSucceedsIfNewKeySerializerRequiresReconfiguration` should now pass. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): **yes** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
