tzulitai opened a new pull request #7429: [FLINK-11280] [rocksdb] Lazily create RocksDBSerializedCompositeKeyBuilder only after restore URL: https://github.com/apache/flink/pull/7429 ## What is the purpose of the change This PR fixes the failing test in master: `StateBackendMigrationTestBase.testStateBackendRestoreSucceedsIfNewKeySerializerRequiresReconfiguration`. The test reconfigures the key serializer and verifies that the reconfigured version is used instead of the original one. The test fails because when writing keys in the `RocksDBKeyedStateBackend`, the `RocksDBSerializedCompositeKeyBuilder` was using the invalid, non-reconfigured key serializer. The culprit is that the composite key builder is created in the constructor of the `RocksDBKeyedStateBackend`. The creation of the builder requires providing a key serializer. This is problematic, because the key serializer may be reconfigured during the restore phase, therefore invalidating the key serializer used by the composite key builder. This commit resolves this by lazily creating the composite key builder only after the restore phase, which would be the point-in-time when we are certain the key serializer will no longer be changed and is final. ## Verifying this change The previously failing test `StateBackendMigrationTestBase.testStateBackendRestoreSucceedsIfNewKeySerializerRequiresReconfiguration` should now pass. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
