tillrohrmann opened a new pull request #7430: [FLINK-10848] Remove container requests after successful container allocation URL: https://github.com/apache/flink/pull/7430 ## What is the purpose of the change This commit removes container requests after containers have been allocated. This prevents that we will request more and more containers from Yarn in case of a recovery. Since we cannot rely on the reported container `Resource`, we remove the container request by using the requested `Resource`. This is due Yarn's `DefaultResourceCalculator` which neglects the number of vCores when allocating containers. At the moment, the requested `Resource` is always the same (`ResourceProfiles` are not yet supported). cc @suez1224. ## Brief change log - Remove container requests after containers have been allocated - Use a fixed `Resource` and `Priority` for container requests --> this allows to retrieve requests from the `AMRMClient` - Keep internal state and `AMRMClientImpl's` state in sync ## Verifying this change - Adopted `YarnResourceManagerTest#testOnContainerCompleted` and `YarnFlinkResourceManagerTest#testYarnFlinkResourceManagerJobManagerLostLeadership` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
