[ https://issues.apache.org/jira/browse/FLINK-11285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737759#comment-16737759 ]
Dian Fu commented on FLINK-11285: --------------------------------- [~twalthr] Currently the Descriptor related classes are all located in package org.apache.flink.table.descriptors. What do you think about moving them to package org.apache.flink.table.api.descriptors? > Change the modifier of CsvTableSourceFactoryBase.createTableSource and > CsvTableSinkFactoryBase.createTableSink to private[flink] > -------------------------------------------------------------------------------------------------------------------------------- > > Key: FLINK-11285 > URL: https://issues.apache.org/jira/browse/FLINK-11285 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Dian Fu > Assignee: Dian Fu > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The modifier of CsvTableSourceFactoryBase.createTableSource and > CsvTableSinkFactoryBase.createTableSink are currently protected. Users should > not see these methods and they should use > CsvBatchTableSinkFactory.createBatchTableSink, > CsvAppendTableSinkFactory.createStreamTableSink, > CsvBatchTableSourceFactory.createBatchTableSource or > CsvAppendTableSourceFactory.createStreamTableSource instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)