kisimple commented on a change in pull request #7430: [FLINK-10848] Remove 
container requests after successful container allocation
URL: https://github.com/apache/flink/pull/7430#discussion_r246241536
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
 ##########
 @@ -402,6 +417,36 @@ public void onContainersAllocated(List<Container> 
containers) {
                });
        }
 
+       private void removeContainerRequest(AMRMClient.ContainerRequest 
pendingContainerRequest) {
+               numPendingContainerRequests--;
+
+               log.info("Removing container request {}. Pending container 
requests {}.", pendingContainerRequest, pendingContainerRequest);
 
 Review comment:
   The second argument should be `numPendingContainerRequests`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to