123avi commented on a change in pull request #7418: FLINK-11053 Documentation -
update scala sample code for bucketing sink according
URL: https://github.com/apache/flink/pull/7418#discussion_r246645781
##########
File path: docs/dev/connectors/filesystem_sink.md
##########
@@ -117,11 +117,11 @@ input.addSink(sink);
</div>
<div data-lang="scala" markdown="1">
{% highlight scala %}
-val input: DataStream[Tuple2[IntWritable, Text]] = ...
+val input: DataStream[(IntWritable, Text)] = ???
-val sink = new BucketingSink[String]("/base/path")
-sink.setBucketer(new DateTimeBucketer[String]("yyyy-MM-dd--HHmm",
ZoneId.of("America/Los_Angeles")))
-sink.setWriter(new SequenceFileWriter[IntWritable, Text]())
+val sink = new BucketingSink[(IntWritable, Text)]("/base/path")
+sink.setBucketer(new DateTimeBucketer("yyyy-MM-dd--HHmm"))
+sink.setWriter(new StringWriter[(IntWritable, Text)]())
Review comment:
@hequn8128 sounds good, Thank you very much. I pushed the correction I did
emphasize the usage of `java.tuple.Tuple2` to avoid the frustration of someone
that will do copy&paste to the example :) .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
