HuangZhenQiu commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum failed TMs in YarnResourceManager
URL: https://github.com/apache/flink/pull/7356#discussion_r246652065
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -825,6 +837,12 @@ protected void closeTaskManagerConnection(final
ResourceID resourceID, final Exc
slotManager.unregisterTaskManager(workerRegistration.getInstanceID());
workerRegistration.getTaskExecutorGateway().disconnectResourceManager(cause);
+ failedContainerSoFar.getAndAdd(1);
+ if (failedContainerSoFar.intValue() >=
maxFailedContainers) {
+ rejectAllPendingSlotRequests(new
MaximumFailedContainersException(
Review comment:
No need. If other TMs can be still alive for restart strategy to make
decision about whether to fail whole job. For per job cluster, if the job
failed, the cluster will terminate by itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
