zentol commented on issue #7417: [FLINK-11268][release] Deploy multiple 
flink-shaded-hadoop2 artifacts
URL: https://github.com/apache/flink/pull/7417#issuecomment-453043597
 
 
   > I'm ok with the format `<Flink-Version>-<Hadoop-Version>`. However, it is 
not aligned with the version format of the flink-shaded artifacts which seems a 
bit odd.
   
   This version scheme is more similar to flink-shaded than using a 
`classifier` is. Every flink-shaded artifact (except flink-shaded _itself_) 
uses a composite version scheme consisting of  
`<shaded-version>-<dependency-version>`.
   
   As for hadoop 3, shaded-hadoop2 would simply not be used for that. It 
remains to be seen, but I believe it to be unlikely that we can find a 
reasonable setup that can cover both versions in 1 module.
   This would also break existing flink-shaded conventions of encoding the 
dependency's major version in the shading pattern and name of the module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to