dawidwys commented on issue #7436: [FLINK-11071][core] add support for dynamic 
proxy classes resolution …
URL: https://github.com/apache/flink/pull/7436#issuecomment-453101329
 
 
   Thanks for the contribution @eaglewatcherwb .
   
   I don't think we should introduce incompatibilities with that change. Having 
two different versions of an interface is a problem in the first place. If it 
occurs the solution would be just to simple leave only one version of the 
proxy. 
   
   @eaglewatcherwb I don't think we should change `SocketWindowWordCount` 
example at all. I would prefer to see a proper unit test for those changes. You 
can check 
`org.apache.flink.runtime.classloading.ClassLoaderTest#testMessageDecodingWithUnavailableClass`
 for inspiration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to