GJL commented on a change in pull request #7441: [FLINK-11156][tests, runtime]
Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9
URL: https://github.com/apache/flink/pull/7441#discussion_r246861639
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
##########
@@ -98,43 +92,23 @@
* least 1). Adding more
checkpoints than this results
* in older checkpoints being
discarded. On recovery,
* we will only start with a
single checkpoint.
- * @param client The Curator ZooKeeper client
- * @param checkpointsPath The ZooKeeper path for the
checkpoints (needs to
- * start with a '/')
- * @param stateStorage State storage to be used to
persist the completed
- * checkpoint
* @param executor to execute blocking calls
* @throws Exception
*/
public ZooKeeperCompletedCheckpointStore(
int maxNumberOfCheckpointsToRetain,
- CuratorFramework client,
- String checkpointsPath,
- RetrievableStateStorageHelper<CompletedCheckpoint>
stateStorage,
- Executor executor) throws Exception {
+ ZooKeeperStateHandleStore<CompletedCheckpoint>
checkpointsInZooKeeper,
+ Executor executor) {
checkArgument(maxNumberOfCheckpointsToRetain >= 1, "Must retain
at least one checkpoint.");
- checkNotNull(stateStorage, "State storage");
this.maxNumberOfCheckpointsToRetain =
maxNumberOfCheckpointsToRetain;
- checkNotNull(client, "Curator client");
- checkNotNull(checkpointsPath, "Checkpoints path");
-
- // Ensure that the checkpoints path exists
- client.newNamespaceAwareEnsurePath(checkpointsPath)
- .ensure(client.getZookeeperClient());
-
- // All operations will have the path as root
- this.client = client.usingNamespace(client.getNamespace() +
checkpointsPath);
-
- this.checkpointsInZooKeeper = new
ZooKeeperStateHandleStore<>(this.client, stateStorage);
+ this.checkpointsInZooKeeper = checkpointsInZooKeeper;
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
