Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1016#issuecomment-134646755
Looks very good. Minor comments that we may address after this pull request:
- The Flink Mini cluster becomes tricky, the configurations ever more
intransparent. This could use a rework.
- You shade curator in Hadoop, but not in Flink. Do we expect collisions
with other systems that use Curator, like newer versions of the Kafka
consumers? (IIRC 0.8.3 starts using Curator).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
