hequn8128 opened a new pull request #7483: [FLINK-11310][table] Convert predicates to IN or NOT_IN for Project URL: https://github.com/apache/flink/pull/7483 ## What is the purpose of the change This pull request convert predicates to IN or NOT_IN for `Project`. In [FLINK-10474](https://issues.apache.org/jira/browse/FLINK-10474), we force translate IN into a predicate to avoid translating to a JOIN. In addition, we add a Rule to convert the predicates back to IN so that we can generate code using a HashSet for the IN. However, [FLINK-10474](https://issues.apache.org/jira/browse/FLINK-10474) only takes Filter into consideration. It would be great to also convert predicates in Project to IN. It not only will improve the performance for the Project, but also will avoid the problem raised in [FLINK-11308](https://issues.apache.org/jira/browse/FLINK-11308), as all predicates will be converted into one IN expression. ## Brief change log - Support convert predicates to IN or NOT IN for `Project` in `ConvertToNotInOrInRule`. Note: We don't need to convert predicates for `Calc` since there is no Calc during `optimizeNormalizeLogicalPlan`. ## Verifying this change This change added tests and can be verified as follows: - Added tests in `CalcTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
