pnowojski commented on a change in pull request #7440: [FLINK-10591][table]
Introduced functions to return time attributes from MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7440#discussion_r247520831
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
##########
@@ -118,8 +126,9 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder)
extends RelShuttle {
}
// materialize all output types
- // TODO allow passing through for rowtime accessor function, once
introduced
- val outputType =
materializerUtils.getRowTypeWithoutIndicators(matchRel.getRowType)
+ val outputType =
materializerUtils.getRowTypeWithoutIndicators(matchRel.getRowType,
+ fieldName => measures.get(fieldName)
+ .exists(r => !FlinkTypeFactory.isTimeIndicatorType(r.getType)))
Review comment:
Doesn't this `!FlinkTypeFactory.isTimeIndicatorType(r.getType)` turn those
lines a no-op? It looks like you are trying to materialize time indicators that
are not time indicators, or am I missing/forgetting something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
