StefanRRichter commented on a change in pull request #7188: [FLINK-10473][State
TTL] TTL state incremental cleanup for heap backend
URL: https://github.com/apache/flink/pull/7188#discussion_r247852062
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlState.java
##########
@@ -82,5 +88,19 @@ public void setCurrentNamespace(N namespace) {
@Override
public void clear() {
original.clear();
+ accessCallback.run();
+ }
+
+ /**
+ * Check if state has expired or not and update it if it has partially
expired.
+ *
+ * @return either non expired (possibly updated) state or null if the
state has expired.
+ */
+ @Nullable
+ public abstract TTLSV checkIfExpiredOrUpdate(@Nonnull TTLSV ttlValue);
Review comment:
This method name sounds still like it should return a boolean as it did in
the beginning, but now it does more so I would consider adjusting the name as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
