sunjincheng121 commented on a change in pull request #7286: [FLINK-8739]
[table] Optimize DISTINCT aggregates to use the same distinct accumulator if
possible
URL: https://github.com/apache/flink/pull/7286#discussion_r248126964
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/AggregateITCase.scala
##########
@@ -119,6 +119,39 @@ class AggregateITCase extends StreamingWithStateTestBase {
assertEquals(expected.sorted, StreamITCase.retractedResults.sorted)
}
+ @Test
+ def testDistinctAGGWithDifferentArgumentOrder(): Unit = {
Review comment:
Can we remove this itcase, and improve `testDistinctAggregate` and the
different argument order, then we can reduce the it test times. What do you
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
