GJL commented on a change in pull request #7447: [FLINK-11294] [test] Remove
legacy JobInfo usage in valid tests
URL: https://github.com/apache/flink/pull/7447#discussion_r248262043
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/StandaloneSubmittedJobGraphStoreTest.java
##########
@@ -33,12 +31,10 @@
* Tests that all operations work and don't change the state.
*/
@Test
- public void testNoOps() throws Exception {
+ public void testNoOps() {
StandaloneSubmittedJobGraphStore jobGraphs = new
StandaloneSubmittedJobGraphStore();
- SubmittedJobGraph jobGraph = new SubmittedJobGraph(
- new JobGraph("testNoOps"),
- new JobInfo(ActorRef.noSender(),
ListeningBehaviour.DETACHED, 0, Integer.MAX_VALUE));
+ SubmittedJobGraph jobGraph = new SubmittedJobGraph(new
JobGraph("testNoOps"), null);
Review comment:
It's better to add a new constructor with only JobGraph as the parameter. I
will add a new commit on top of yours to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
